feat(analyzer): Analyze queries using a running PostgreSQL database#2805

kyleconroy · 2023-10-05T01:04:34Z

94 of the open issues on sqlc are related to the analyzer. There are many cases where the current analyzer produces false positives or false negatives.

sqlx and some other projects have proven that it's possible to extract query metadata from a running database.

This approach is a bit different, in that the database analysis is layered on top of the existing query analyzer. We use the existing analysis for better name and NULL inference.

This PR is an obvious work in progress, but I'm happy enough with the result to share an early peek.

94 of the open issues on sqlc are related to the analyzer. There are many cases where the current analyzer produces false positives or false negatives. sqlx and some other projects have proven that it's possible to extract query metadata from a running database. This approach is a bit different, in that the database analysis is layered on top of the existing query analyzer. We use the new analysis to provide better type information and support a wider set of cases when the existing analyzer fails.

Add a `contexts` key to exec.json to opt certain tests into or out of database-backed analysis. Fix many incorrect test cases that didn't run against an actual database.

internal/engine/postgresql/pg_catalog.go

internal/sql/validate/func_call.go

internal/compiler/resolve.go

internal/config/config.go

internal/endtoend/endtoend_test.go

…qlc-dev#2805) * feat(analyzer): Analyze queries using a running PostgreSQL database 94 of the open issues on sqlc are related to the analyzer. There are many cases where the current analyzer produces false positives or false negatives. sqlx and some other projects have proven that it's possible to extract query metadata from a running database. This approach is a bit different, in that the database analysis is layered on top of the existing query analyzer. We use the new analysis to provide better type information and support a wider set of cases when the existing analyzer fails. * test(analyzer): Update endtoend tests for new analyzer Add a `contexts` key to exec.json to opt certain tests into or out of database-backed analysis. Fix many incorrect test cases that didn't run against an actual database.

kyleconroy mentioned this pull request Oct 6, 2023
feat(sql/ast): Render AST to SQL #2815
Merged

kyleconroy changed the title ~~feat(analyzer): Analyze queryies using a PostgreSQL database~~feat(analyzer): Analyze queries using a running PostgreSQL databaseOct 10, 2023

kyleconroy added 2 commits October 10, 2023 16:46

test(analyzer): Update endtoend tests for new analyzer
48f638b
Add a `contexts` key to exec.json to opt certain tests into or out of database-backed analysis. Fix many incorrect test cases that didn't run against an actual database.

kyleconroy force-pushed the kyle/analyzer-pg-prepare branch from a762b00 to 48f638bCompare October 10, 2023 23:49

kyleconroy commented Oct 10, 2023
View reviewed changes

internal/engine/postgresql/pg_catalog.go Outdated Show resolvedHide resolved