Avoid generating empty Go imports statement#3135
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
andrewmbenton commented Jan 17, 2024
I think this will likely require updating some test output. |
ContributorAuthor
mikeschinkel commented Jan 17, 2024
@andrewmbenton — My bad. I was in a haste and forgot to run tests locally. I've removed |
ContributorAuthor
mikeschinkel commented Feb 3, 2024
@andrewmbenton — Just curious if this might be something you will consider merging, now that the tests all work? |
lisitsky pushed a commit to lisitsky/sqlc that referenced this pull request Jun 21, 2024
* Avoid generating empty Go imports statement Maybe fixessqlc-dev#3134 * Remove `import ()` from `testdata` golden files
alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
* Avoid generating empty Go imports statement Maybe fixessqlc-dev#3134 * Remove `import ()` from `testdata` golden files
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#3134, hopefully.