Fix incorrect generate model names for "metadata" suffix#3553
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
qanghaaforce-pushed the fix/incorrect_generate_model_names branch 2 times, most recently from 853d233 to 89c110bCompare
Comment on lines 7 to 9
| typeBonusestruct{ | ||
| IDstring | ||
| } |
Collaborator
There was a problem hiding this comment.
This appears to still be wrong here?
ContributorAuthor
There was a problem hiding this comment.
Ah sorry, I just deleted this one from PR 👍
qanghaa changed the title 
kyleconroyforce-pushed the fix/incorrect_generate_model_names branch from 4072241 to 17fea60Comparekyleconroy merged commit 58674b4 into sqlc-dev:main 8 checks passed
Uh oh!
There was an error while loading. Please reload this page.
alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FixTable "bonuses" and "product_metadata" incorrectly generates model name. #3552