Skip to content

Fix panic for DELETE with JOIN on subquery#4023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kyleconroy merged 1 commit into from
Aug 2, 2025
Merged

Fix panic for DELETE with JOIN on subquery #4023

kyleconroy merged 1 commit into from
Aug 2, 2025

Conversation

@gwillem
Copy link
Contributor

@gwillemgwillem commented Jul 17, 2025•
edited
Loading

Fixes#3848

This would create a panic:

DELETE pt FROM primary_table pt JOIN (SELECT1as id) jt ONpt.id=jt.id;
panic: expected range var github.com/sqlc-dev/sqlc/internal/engine/dolphin.convertToRangeVarList(0x140000669c0?, 0x140008f0390)

@dosubotdosubotbot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 17, 2025
@kyleconroykyleconroy merged commit eb4b0b5 into sqlc-dev:mainAug 2, 2025
8 checks passed
@gwillemgwillem deleted the wdg/fix-delete-join-subquery branch August 3, 2025 20:49
@BrewTestBotBrewTestBot mentioned this pull request Sep 1, 2025
Merged
alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
@gwillem
Support DELETE with JOIN on subquery (sqlc-dev#4023)
afda9c3
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:SThis PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Delete query with join returns panic: expected range var error

2 participants

@gwillem@kyleconroy