Skip to content

Replace wrong yaml package usage#475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ske-prow merged 1 commit into from
Jan 21, 2026
Merged

Replace wrong yaml package usage #475

ske-prow merged 1 commit into from
Jan 21, 2026

Conversation

@xoxys
Copy link
Member

@xoxysxoxys commented Jan 21, 2026•
edited
Loading

How to categorize this PR?

/kind regression

What this PR does / why we need it:

The PR #352 introduced the usage of the package go.yaml.in/yaml/v2 accidentally. Switch to already used package gopkg.in/yaml.v3.

@ske-prowske-prowbot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jan 21, 2026
@xoxysxoxys requested a review from a teamJanuary 21, 2026 09:52
@ske-prowske-prowbot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 21, 2026
@xoxysxoxys added the kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution label Jan 21, 2026
@ske-prowske-prowbot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jan 21, 2026
ftl
ftl approved these changes Jan 21, 2026
View reviewed changes
@ske-prowske-prowbot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2026
@ske-prow
Copy link

ske-prowbot commented Jan 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ftl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow
Copy link

ske-prowbot commented Jan 21, 2026

LGTM label has been added.

DetailsGit tree hash: 02e02798a54352156f39bcaf32be83517b8f3390

@ske-prowske-prowbot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2026
@ske-prowske-prowbot merged commit 3a42e7c into mainJan 21, 2026
3 checks passed
@ske-prowske-prowbot deleted the fix-yaml branch January 21, 2026 10:51
@xoxys
Copy link
MemberAuthor

xoxys commented Jan 21, 2026

/cherry-pick release-v1.31
/cherry-pick release-v1.32
/cherry-pick release-v1.33
/cherry-pick release-v1.34

@stackit-ske
Copy link

stackit-ske commented Jan 21, 2026

@xoxys: new pull request created: #484

Details

In response to this:

/cherry-pick release-v1.31
/cherry-pick release-v1.32
/cherry-pick release-v1.33
/cherry-pick release-v1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-skestackit-ske mentioned this pull request Jan 21, 2026
Merged
@stackit-ske
Copy link

stackit-ske commented Jan 21, 2026

@xoxys: new pull request created: #485

Details

In response to this:

/cherry-pick release-v1.31
/cherry-pick release-v1.32
/cherry-pick release-v1.33
/cherry-pick release-v1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-skestackit-ske mentioned this pull request Jan 21, 2026
Merged
@stackit-ske
Copy link

stackit-ske commented Jan 21, 2026

@xoxys: new pull request created: #486

Details

In response to this:

/cherry-pick release-v1.31
/cherry-pick release-v1.32
/cherry-pick release-v1.33
/cherry-pick release-v1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-skestackit-ske mentioned this pull request Jan 21, 2026
Merged
@stackit-ske
Copy link

stackit-ske commented Jan 21, 2026

@xoxys: new pull request created: #488

Details

In response to this:

/cherry-pick release-v1.31
/cherry-pick release-v1.32
/cherry-pick release-v1.33
/cherry-pick release-v1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-skestackit-ske mentioned this pull request Jan 21, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ftlftlftl approved these changes

Assignees

@ftlftl

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.kind/regressionBug that hit us already in the past and that is reappearing/requires a proper solutionlgtmIndicates that a PR is ready to be merged.size/XSDenotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xoxys@stackit-ske@ftl