Skip to content

Conversation

@Fyusel
Copy link
Contributor

@FyuselFyusel commented Oct 28, 2025

Description

The ConfigureClient() method was implemented for all clients with almost the same code. In order to reduce this code duplication a generic method was defined. The ConfigureClient() method is still present but is only a wrapper which means that the normal code does not need to be changed at all. This generic function still uses the region as parameter for some clients. This will be adjusted when all services have implemented the region adjustment.

For testing just execute the list command for every service (except the git service).

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@FyuselFyusel requested a review from a team as a code ownerOctober 28, 2025 11:20
@FyuselFyusel marked this pull request as draft October 28, 2025 12:27
@FyuselFyuselforce-pushed the refactor-configure-client branch from b8bd1f8 to 8c9e1c3CompareOctober 28, 2025 12:33
@FyuselFyusel marked this pull request as ready for review October 28, 2025 12:59
marceljk
marceljk previously approved these changes Oct 31, 2025
@FyuselFyuselforce-pushed the refactor-configure-client branch from d8a3807 to 8308cb1CompareNovember 3, 2025 07:49
@FyuselFyuselforce-pushed the refactor-configure-client branch from 8308cb1 to 3201a41CompareNovember 3, 2025 08:44
@FyuselFyuselforce-pushed the refactor-configure-client branch from 3201a41 to 997863fCompareNovember 3, 2025 09:54
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted PackagesCoverage Δ🤖
github.com/stackitcloud/stackit-cli/.github/docs/contribution-guide0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/git/flavor/list56.52% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/create50.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/delete17.02% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/describe43.75% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/list56.52% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/config71.27% (+0.11%)👍
github.com/stackitcloud/stackit-cli/internal/pkg/generic-client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/alb/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/authorization/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/dns/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/git/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/iaas/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/kms/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/load-balancer/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/logme/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/mariadb/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/mongodbflex/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/object-storage/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/observability/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/opensearch/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/postgresflex/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/rabbitmq/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/redis/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/resourcemanager/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/runcommand/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/secrets-manager/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/serverbackup/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/serverosupdate/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/service-account/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/service-enablement/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/ske/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/sqlserverflex/client0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed FileCoverage ΔTotalCoveredMissed🤖
github.com/stackitcloud/stackit-cli/.github/docs/contribution-guide/client.go0.00% (ø)000
github.com/stackitcloud/stackit-cli/internal/cmd/git/flavor/list/list.go56.52% (ø)462620
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/create/create.go50.00% (ø)522626
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/delete/delete.go17.02% (ø)47839
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/describe/describe.go43.75% (ø)482127
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/list/list.go56.52% (ø)462620
github.com/stackitcloud/stackit-cli/internal/pkg/config/config.go90.16% (+0.16%)61 (+1)55 (+1)6👍
github.com/stackitcloud/stackit-cli/internal/pkg/generic-client/generic_client.go0.00% (ø)17 (+17)017 (+17)
github.com/stackitcloud/stackit-cli/internal/pkg/services/alb/client/client.go0.00% (ø)1 (-14)01 (-14)
github.com/stackitcloud/stackit-cli/internal/pkg/services/authorization/client/client.go0.00% (ø)1 (-14)01 (-14)
github.com/stackitcloud/stackit-cli/internal/pkg/services/dns/client/client.go0.00% (ø)1 (-14)01 (-14)
github.com/stackitcloud/stackit-cli/internal/pkg/services/git/client/client.go0.00% (ø)1 (-17)01 (-17)
github.com/stackitcloud/stackit-cli/internal/pkg/services/iaas/client/client.go0.00% (ø)1 (-16)01 (-16)
github.com/stackitcloud/stackit-cli/internal/pkg/services/kms/client/client.go0.00% (ø)1 (-14)01 (-14)
github.com/stackitcloud/stackit-cli/internal/pkg/services/load-balancer/client/client.go0.00% (ø)1 (-14)01 (-14)
github.com/stackitcloud/stackit-cli/internal/pkg/services/logme/client/client.go0.00% (ø)1 (-15)01 (-15)
github.com/stackitcloud/stackit-cli/internal/pkg/services/mariadb/client/client.go0.00% (ø)1 (-15)01 (-15)
github.com/stackitcloud/stackit-cli/internal/pkg/services/mongodbflex/client/client.go0.00% (ø)1 (-14)01 (-14)
github.com/stackitcloud/stackit-cli/internal/pkg/services/object-storage/client/client.go0.00% (ø)1 (-15)01 (-15)
github.com/stackitcloud/stackit-cli/internal/pkg/services/observability/client/client.go0.00% (ø)1 (-15)01 (-15)
github.com/stackitcloud/stackit-cli/internal/pkg/services/opensearch/client/client.go0.00% (ø)1 (-15)01 (-15)
github.com/stackitcloud/stackit-cli/internal/pkg/services/postgresflex/client/client.go0.00% (ø)1 (-15)01 (-15)
github.com/stackitcloud/stackit-cli/internal/pkg/services/rabbitmq/client/client.go0.00% (ø)1 (-15)01 (-15)
github.com/stackitcloud/stackit-cli/internal/pkg/services/redis/client/client.go0.00% (ø)1 (-15)01 (-15)
github.com/stackitcloud/stackit-cli/internal/pkg/services/resourcemanager/client/client.go0.00% (ø)1 (-14)01 (-14)
github.com/stackitcloud/stackit-cli/internal/pkg/services/runcommand/client/client.go0.00% (ø)1 (-15)01 (-15)
github.com/stackitcloud/stackit-cli/internal/pkg/services/secrets-manager/client/client.go0.00% (ø)1 (-15)01 (-15)
github.com/stackitcloud/stackit-cli/internal/pkg/services/serverbackup/client/client.go0.00% (ø)1 (-16)01 (-16)
github.com/stackitcloud/stackit-cli/internal/pkg/services/serverosupdate/client/client.go0.00% (ø)1 (-15)01 (-15)
github.com/stackitcloud/stackit-cli/internal/pkg/services/service-account/client/client.go0.00% (ø)1 (-14)01 (-14)
github.com/stackitcloud/stackit-cli/internal/pkg/services/service-enablement/client/client.go0.00% (ø)1 (-16)01 (-16)
github.com/stackitcloud/stackit-cli/internal/pkg/services/ske/client/client.go0.00% (ø)1 (-15)01 (-15)
github.com/stackitcloud/stackit-cli/internal/pkg/services/sqlserverflex/client/client.go0.00% (ø)1 (-14)01 (-14)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@FyuselFyusel merged commit fc25893 into mainNov 3, 2025
5 checks passed
@FyuselFyusel deleted the refactor-configure-client branch November 3, 2025 10:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Fyusel@rubenhoenle@marceljk