Skip to content

Conversation

@cgoetz-inovex
Copy link
Contributor

@cgoetz-inovexcgoetz-inovex commented Nov 19, 2025

Description

Issue: STACKITCLI-70

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@cgoetz-inovexcgoetz-inovex requested a review from a team as a code ownerNovember 19, 2025 16:39
@rubenhoenle
Copy link
Member

Btw, please always add the Jira issue ID to your PR description if possible :)

rubenhoenle
rubenhoenle previously approved these changes Jan 8, 2026
- fix `ID` spelling - add missing new line at end of output - rm TODO comment
@github-actions
Copy link

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@rubenhoenle
Copy link
Member

@cgoetz-inovex can you take care of the failing CI pipeline please?

rubenhoenle
rubenhoenle previously approved these changes Jan 26, 2026
@github-actions
Copy link

Merging this branch changes the coverage (2 decrease, 11 increase)

Impacted PackagesCoverage Δ🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/create75.00% (+75.00%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/delete27.59% (+27.59%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/describe88.89% (+88.89%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/list80.60% (+80.60%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/update78.42% (+78.42%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/config/set90.51% (+0.21%)👍
github.com/stackitcloud/stackit-cli/internal/cmd/config/unset35.25% (-0.05%)👎
github.com/stackitcloud/stackit-cli/internal/pkg/config70.04% (+0.11%)👍
github.com/stackitcloud/stackit-cli/internal/pkg/flags59.15% (+0.86%)👍
github.com/stackitcloud/stackit-cli/internal/pkg/print76.79% (+1.04%)👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/cdn/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/cdn/utils81.82% (+81.82%)🌟
github.com/stackitcloud/stackit-cli/internal/pkg/testutils50.99% (-3.23%)👎
github.com/stackitcloud/stackit-cli/internal/pkg/utils61.39% (+4.24%)👍

Coverage by file

Changed files (no unit tests)

Changed FileCoverage ΔTotalCoveredMissed🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/beta.go0.00% (ø)10 (+1)010 (+1)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/cdn.go0.00% (ø)4 (+4)04 (+4)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/create/create.go75.00% (+75.00%)120 (+120)90 (+90)30 (+30)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/delete/delete.go27.59% (+27.59%)29 (+29)8 (+8)21 (+21)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/describe/describe.go88.89% (+88.89%)117 (+117)104 (+104)13 (+13)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/distribution.go0.00% (ø)8 (+8)08 (+8)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/list/list.go80.60% (+80.60%)67 (+67)54 (+54)13 (+13)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/update/update.go78.42% (+78.42%)139 (+139)109 (+109)30 (+30)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/config/set/set.go90.51% (+0.21%)137 (+3)124 (+3)13👍
github.com/stackitcloud/stackit-cli/internal/cmd/config/unset/unset.go35.25% (-0.05%)122 (+3)43 (+1)79 (+2)👎
github.com/stackitcloud/stackit-cli/internal/pkg/config/config.go90.62% (+0.15%)64 (+1)58 (+1)6👍
github.com/stackitcloud/stackit-cli/internal/pkg/flags/flag_to_value.go25.81% (+8.08%)93 (+14)24 (+10)69 (+4)👍
github.com/stackitcloud/stackit-cli/internal/pkg/print/print.go73.83% (+2.54%)107 (+6)79 (+7)28 (-1)👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/cdn/client/client.go0.00% (ø)1 (+1)01 (+1)
github.com/stackitcloud/stackit-cli/internal/pkg/services/cdn/utils/utils.go81.82% (+81.82%)22 (+22)18 (+18)4 (+4)🌟
github.com/stackitcloud/stackit-cli/internal/pkg/testutils/testutils.go0.00% (ø)60 (+9)060 (+9)
github.com/stackitcloud/stackit-cli/internal/pkg/utils/strings.go63.64% (+15.81%)33 (+10)21 (+10)12🎉

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/config/unset/unset_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/flags/flag_to_value_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/print/print_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/cdn/utils/utils_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/utils/strings_test.go

@github-actions
Copy link

Merging this branch changes the coverage (2 decrease, 11 increase)

Impacted PackagesCoverage Δ🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/create75.00% (+75.00%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/delete27.59% (+27.59%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/describe88.89% (+88.89%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/list80.60% (+80.60%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/update78.42% (+78.42%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/config/set90.71% (+0.20%)👍
github.com/stackitcloud/stackit-cli/internal/cmd/config/unset35.20% (-0.05%)👎
github.com/stackitcloud/stackit-cli/internal/pkg/config70.14% (+0.11%)👍
github.com/stackitcloud/stackit-cli/internal/pkg/flags59.15% (+0.86%)👍
github.com/stackitcloud/stackit-cli/internal/pkg/print76.79% (+1.04%)👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/cdn/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/cdn/utils81.82% (+81.82%)🌟
github.com/stackitcloud/stackit-cli/internal/pkg/testutils50.99% (-3.23%)👎
github.com/stackitcloud/stackit-cli/internal/pkg/utils61.39% (+4.24%)👍

Coverage by file

Changed files (no unit tests)

Changed FileCoverage ΔTotalCoveredMissed🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/beta.go0.00% (ø)11 (+1)011 (+1)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/cdn.go0.00% (ø)4 (+4)04 (+4)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/create/create.go75.00% (+75.00%)120 (+120)90 (+90)30 (+30)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/delete/delete.go27.59% (+27.59%)29 (+29)8 (+8)21 (+21)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/describe/describe.go88.89% (+88.89%)117 (+117)104 (+104)13 (+13)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/distribution.go0.00% (ø)8 (+8)08 (+8)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/list/list.go80.60% (+80.60%)67 (+67)54 (+54)13 (+13)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/update/update.go78.42% (+78.42%)139 (+139)109 (+109)30 (+30)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/config/set/set.go90.71% (+0.20%)140 (+3)127 (+3)13👍
github.com/stackitcloud/stackit-cli/internal/cmd/config/unset/unset.go35.20% (-0.05%)125 (+3)44 (+1)81 (+2)👎
github.com/stackitcloud/stackit-cli/internal/pkg/config/config.go90.77% (+0.14%)65 (+1)59 (+1)6👍
github.com/stackitcloud/stackit-cli/internal/pkg/flags/flag_to_value.go25.81% (+8.08%)93 (+14)24 (+10)69 (+4)👍
github.com/stackitcloud/stackit-cli/internal/pkg/print/print.go73.83% (+2.54%)107 (+6)79 (+7)28 (-1)👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/cdn/client/client.go0.00% (ø)1 (+1)01 (+1)
github.com/stackitcloud/stackit-cli/internal/pkg/services/cdn/utils/utils.go81.82% (+81.82%)22 (+22)18 (+18)4 (+4)🌟
github.com/stackitcloud/stackit-cli/internal/pkg/testutils/testutils.go0.00% (ø)60 (+9)060 (+9)
github.com/stackitcloud/stackit-cli/internal/pkg/utils/strings.go63.64% (+15.81%)33 (+10)21 (+10)12🎉

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/config/unset/unset_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/flags/flag_to_value_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/print/print_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/cdn/utils/utils_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/utils/strings_test.go

@cgoetz-inovexcgoetz-inovex merged commit d65f218 into mainJan 27, 2026
3 checks passed
@cgoetz-inovexcgoetz-inovex deleted the feat/STACKITCLI-70-add-cdn-distribution-beta-cmds branch January 27, 2026 09:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@cgoetz-inovex@rubenhoenle@marceljk@stackit-pipeline@PietvanderMeulen@JorTurFer