Skip to content

Conversation

@GokceGK
Copy link
Contributor

@GokceGKGokceGK commented Dec 16, 2025

Description

Related to STACKITCLI-292

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@GokceGKGokceGK requested a review from a team as a code ownerDecember 16, 2025 15:53
@GokceGKGokceGK marked this pull request as draft December 16, 2025 15:54
@GokceGKGokceGK marked this pull request as ready for review January 7, 2026 11:13
@GokceGKGokceGK enabled auto-merge (squash) January 12, 2026 13:43
rubenhoenle
rubenhoenle previously approved these changes Jan 26, 2026
@github-actions
Copy link

Merging this branch changes the coverage (1 decrease, 8 increase)

Impacted PackagesCoverage Δ🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/create42.19% (+42.19%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/delete22.92% (+22.92%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/describe71.74% (+71.74%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/list54.17% (+54.17%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/update53.57% (+53.57%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/config/set90.51% (+0.21%)👍
github.com/stackitcloud/stackit-cli/internal/cmd/config/unset35.25% (-0.05%)👎
github.com/stackitcloud/stackit-cli/internal/pkg/config70.04% (+0.11%)👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/logs/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/logs/utils100.00% (+100.00%)🌟

Coverage by file

Changed files (no unit tests)

Changed FileCoverage ΔTotalCoveredMissed🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/beta.go0.00% (ø)10 (+1)010 (+1)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/create/create.go42.19% (+42.19%)64 (+64)27 (+27)37 (+37)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/delete/delete.go22.92% (+22.92%)48 (+48)11 (+11)37 (+37)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/describe/describe.go71.74% (+71.74%)46 (+46)33 (+33)13 (+13)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/instance.go0.00% (ø)8 (+8)08 (+8)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/list/list.go54.17% (+54.17%)48 (+48)26 (+26)22 (+22)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/update/update.go53.57% (+53.57%)56 (+56)30 (+30)26 (+26)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/logs.go0.00% (ø)4 (+4)04 (+4)
github.com/stackitcloud/stackit-cli/internal/cmd/config/set/set.go90.51% (+0.21%)137 (+3)124 (+3)13👍
github.com/stackitcloud/stackit-cli/internal/cmd/config/unset/unset.go35.25% (-0.05%)122 (+3)43 (+1)79 (+2)👎
github.com/stackitcloud/stackit-cli/internal/pkg/config/config.go90.62% (+0.15%)64 (+1)58 (+1)6👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/logs/client/client.go0.00% (ø)1 (+1)01 (+1)
github.com/stackitcloud/stackit-cli/internal/pkg/services/logs/utils/utils.go100.00% (+100.00%)8 (+8)8 (+8)0🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/instance/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/config/unset/unset_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/logs/utils/utils_test.go

@GokceGKGokceGK merged commit c74c23c into mainJan 26, 2026
3 checks passed
@GokceGKGokceGK deleted the feature/onboard-logs-service branch January 26, 2026 15:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@GokceGK@rubenhoenle