Skip to content

Conversation

@Fyusel
Copy link
Contributor

  • export-policy
  • performance-class
  • resource-pool
  • share
  • snapshot

Description

relates to #1234

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@FyuselFyusel requested a review from a team as a code ownerDecember 19, 2025 10:23
@FyuselFyuselforce-pushed the feat/onboard-sfs-commands branch 2 times, most recently from bef70fe to 5e48586CompareDecember 19, 2025 10:39
cgoetz-inovex
cgoetz-inovex previously approved these changes Dec 19, 2025
- export-policy - performance-class - resource-pool - share - snapshot Signed-off-by: Alexander Dahmen <[email protected]>
@FyuselFyuselforce-pushed the feat/onboard-sfs-commands branch from cebe27e to 58c6d95CompareDecember 19, 2025 13:27
@FyuselFyusel enabled auto-merge (squash) December 19, 2025 13:27
@FyuselFyusel merged commit 0916439 into mainDec 19, 2025
3 checks passed
@FyuselFyusel deleted the feat/onboard-sfs-commands branch December 19, 2025 13:36
@github-actions
Copy link

Merging this branch changes the coverage (1 decrease, 22 increase)

Impacted PackagesCoverage Δ🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/create51.92% (+51.92%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/delete29.41% (+29.41%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/describe50.00% (+50.00%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/list52.08% (+52.08%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/update50.75% (+50.75%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/performance-class0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/performance-class/list51.35% (+51.35%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/create52.38% (+52.38%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/delete34.15% (+34.15%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/describe61.43% (+61.43%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/list54.90% (+54.90%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/update48.33% (+48.33%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/create43.75% (+43.75%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/delete29.17% (+29.17%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/describe50.68% (+50.68%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/list53.70% (+53.70%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/update42.42% (+42.42%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/create47.83% (+47.83%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/delete36.84% (+36.84%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/describe70.21% (+70.21%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/list60.87% (+60.87%)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/config/set90.08% (+0.23%)👍
github.com/stackitcloud/stackit-cli/internal/cmd/config/unset35.34% (-0.05%)👎
github.com/stackitcloud/stackit-cli/internal/pkg/config71.38% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/sfs/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/sfs/utils83.33% (+83.33%)🌟
github.com/stackitcloud/stackit-cli/internal/pkg/testutils0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed FileCoverage ΔTotalCoveredMissed🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/beta.go0.00% (ø)8 (+1)08 (+1)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/create/create.go51.92% (+51.92%)52 (+52)27 (+27)25 (+25)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/delete/delete.go29.41% (+29.41%)34 (+34)10 (+10)24 (+24)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/describe/describe.go50.00% (+50.00%)58 (+58)29 (+29)29 (+29)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/export-policy.go0.00% (ø)8 (+8)08 (+8)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/list/list.go52.08% (+52.08%)48 (+48)25 (+25)23 (+23)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/update/update.go50.75% (+50.75%)67 (+67)34 (+34)33 (+33)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/performance-class/list/list.go51.35% (+51.35%)37 (+37)19 (+19)18 (+18)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/performance-class/performance_class.go0.00% (ø)4 (+4)04 (+4)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/create/create.go52.38% (+52.38%)63 (+63)33 (+33)30 (+30)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/delete/delete.go34.15% (+34.15%)41 (+41)14 (+14)27 (+27)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/describe/describe.go61.43% (+61.43%)70 (+70)43 (+43)27 (+27)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/list/list.go54.90% (+54.90%)51 (+51)28 (+28)23 (+23)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/resource_pool.go0.00% (ø)8 (+8)08 (+8)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/update/update.go48.33% (+48.33%)60 (+60)29 (+29)31 (+31)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/sfs.go0.00% (ø)8 (+8)08 (+8)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/create/create.go43.75% (+43.75%)64 (+64)28 (+28)36 (+36)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/delete/delete.go29.17% (+29.17%)48 (+48)14 (+14)34 (+34)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/describe/describe.go50.68% (+50.68%)73 (+73)37 (+37)36 (+36)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/list/list.go53.70% (+53.70%)54 (+54)29 (+29)25 (+25)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/share.go0.00% (ø)8 (+8)08 (+8)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/update/update.go42.42% (+42.42%)66 (+66)28 (+28)38 (+38)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/create/create.go47.83% (+47.83%)46 (+46)22 (+22)24 (+24)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/delete/delete.go36.84% (+36.84%)38 (+38)14 (+14)24 (+24)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/describe/describe.go70.21% (+70.21%)47 (+47)33 (+33)14 (+14)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/list/list.go60.87% (+60.87%)46 (+46)28 (+28)18 (+18)🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/snapshot.go0.00% (ø)7 (+7)07 (+7)
github.com/stackitcloud/stackit-cli/internal/cmd/config/set/set.go90.08% (+0.23%)131 (+3)118 (+3)13👍
github.com/stackitcloud/stackit-cli/internal/cmd/config/unset/unset.go35.34% (-0.05%)116 (+3)41 (+1)75 (+2)👎
github.com/stackitcloud/stackit-cli/internal/pkg/config/config.go90.32% (ø)62566
github.com/stackitcloud/stackit-cli/internal/pkg/services/sfs/client/client.go0.00% (ø)1 (+1)01 (+1)
github.com/stackitcloud/stackit-cli/internal/pkg/services/sfs/utils/utils.go83.33% (+83.33%)18 (+18)15 (+15)3 (+3)🌟
github.com/stackitcloud/stackit-cli/internal/pkg/testutils/options.go0.00% (ø)3 (+3)03 (+3)
github.com/stackitcloud/stackit-cli/internal/pkg/testutils/testutils.go0.00% (ø)51 (+7)051 (+7)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/performance-class/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/config/unset/unset_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/sfs/utils/utils_test.go

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Fyusel@cgoetz-inovex