- Notifications
You must be signed in to change notification settings - Fork 279
Add bower dependencies#136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eriwen commented Oct 16, 2015
👍 |
oliversalzburg commented Oct 16, 2015
@eriwen We should probably tag stacktrace-gps and stacktrace.js with a patch update and update the bower.json to that version. Then the dependencies should be pulled in. Another option I was considering was to specify the |
eriwen commented Oct 16, 2015
@oliversalzburg Yes, we should tag and publish a new release for those projects. You no longer have to wait for me to publish to npm! Make sure to bump and push gps, then bump the versions in stacktrace.js, tag and push that. Regarding the bower dependencies, we used |
oliversalzburg commented Oct 18, 2015
@eriwen Okay, so, if we set the Unless you disagree, I would make that change, merge, tag, push and npm publish :) |
bower.json Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's bump this to 2.3.0
eriwen commented Oct 19, 2015
Once we can rebase this PR on the HEAD of master and update the stacktrace-gps dependency, you can merge this and push a new version @oliversalzburg. Thanks! |
oliversalzburg commented Oct 19, 2015
I didn't change the I pushed a 1.0.1 tag and published to npm. I didn't touch the dependencies as a I'll probably reference the bower dependency in our own projects very soon and then I'll get some real-world experience and adjust accordingly, if necessary. |
eriwen commented Nov 7, 2015
@oliversalzburg Yeah, this works just fine. The only possible hangup I can see is the complexity of including all dependencies if a consumer does not use the minified version at |
Fixes#134