Add support for percent encoded requests (#52)

Author: Andrew-Lees11

Sources/NIOHTTPClient/HTTPHandler.swift

@@ -228,7 +228,8 @@ extension HTTPClientResponseDelegate{
 
 internalextensionURL{
 varuri:String{
-return path.isEmpty ?"/": path +(query.map{"?"+ $0 }??"")
+leturlEncodedPath= path.addingPercentEncoding(withAllowedCharacters:.urlPathAllowed)?? path
+return path.isEmpty ?"/": urlEncodedPath +(query.map{"?"+ $0 }??"")
 }
 
 func hasTheSameOrigin(as other:URL)->Bool{

Tests/NIOHTTPClientTests/HTTPClientTestUtils.swift

@@ -246,6 +246,14 @@ internal final class HttpBinHandler: ChannelInboundHandler{
  headers.add(name:"Location", value:"http://127.0.0.1:\(port)/echohostheader")
 self.resps.append(HTTPResponseBuilder(status:.found, headers: headers))
 return
+ // Since this String is taken from URL.path, the percent encoding has been removed
+case"/percent encoded":
+if req.method !=.GET {
+self.resps.append(HTTPResponseBuilder(status:.methodNotAllowed))
+return
+}
+self.resps.append(HTTPResponseBuilder(status:.ok))
+return
 case"/echohostheader":
 varbuilder=HTTPResponseBuilder(status:.ok)
 lethostValue= req.headers["Host"].first ??""

Tests/NIOHTTPClientTests/HTTPClientTests+XCTest.swift

@@ -32,6 +32,7 @@ extension HTTPClientTests{
 ("testPostHttps", testPostHttps),
 ("testHttpRedirect", testHttpRedirect),
 ("testHttpHostRedirect", testHttpHostRedirect),
+("testPercentEncoded", testPercentEncoded),
 ("testMultipleContentLengthHeaders", testMultipleContentLengthHeaders),
 ("testStreaming", testStreaming),
 ("testRemoteClose", testRemoteClose),

Tests/NIOHTTPClientTests/HTTPClientTests.swift

@@ -135,6 +135,18 @@ class HTTPClientTests: XCTestCase{
 lethostName=try decoder.decode([String:String].self, from: responseData)["data"]
 XCTAssert(hostName =="127.0.0.1")
 }
+
+func testPercentEncoded()throws{
+lethttpBin=HttpBin()
+lethttpClient=HTTPClient(eventLoopGroupProvider:.createNew)
+defer{
+try! httpClient.syncShutdown()
+ httpBin.shutdown()
+}
+
+letresponse=try httpClient.get(url:"http://localhost:\(httpBin.port)/percent%20encoded").wait()
+XCTAssertEqual(.ok, response.status)
+}
 
 func testMultipleContentLengthHeaders()throws{
 lethttpClient=HTTPClient(eventLoopGroupProvider:.createNew)