feat: Add support for percent encoded requests#52
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
swift-server-bot commented Jun 25, 2019
Can one of the admins verify this patch? |
Collaborator
artemredkin commented Jun 25, 2019
@swift-server-bot test this please |
artemredkin approved these changes Jun 25, 2019
Collaborator
artemredkin commented Jun 25, 2019
Looks good, thank you! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #42
Previously when you made HTTP requests to a route with percent encoding, the encoding would be removed causing the request to fail.
This request adds the percent encoding back to the path when you get the uri so that it can be correctly processed.