Skip to content

Conversation

@weissi
Copy link
Contributor

No description provided.

@weissiweissi requested a review from tomerdDecember 17, 2019 21:47
@tomerdtomerd merged commit 669745f into masterDec 18, 2019
args:
ubuntu_version: "bionic"
swift_version: "5.1"
swift_version: "5.1.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this means we would need to keep this up to date as minor revisions are released

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomerd Yes. Is there another way to force the CI to pull the latest 5.1?

Copy link
Contributor

@tomerdtomerdDec 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue here is that docker will catch the 5.1 image (the tag. latest is a special case), so the only way would be to forcibly invalidate the cache which is not ideal

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I think manually bumping is fine for now. Or we implement something where it’d kill the cache once a week or so?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we can do that. we can also create a CI job that will nuke the relevant cache for a specific version. this may be part of the checklist when we release new versions?

@tomerdtomerd added the 🔨 semver/patch No public API change. label Dec 18, 2019
@weissiweissi deleted the jw-513 branch May 13, 2020 13:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 semver/patchNo public API change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@weissi@tomerd