Skip to content

Conversation

@tomerd
Copy link
Contributor

motivation: fix doc generation - sourcekitten requires Swift 5.2

changes: expose the doc generation task on the 5.3 docker-compose file so we can trigger it there

@tomerdtomerd linked an issue Jan 22, 2021 that may be closed by this pull request
motivation: fix doc generation - sourcekitten has a new version changes: * sourcekitten now requires Swift 5.2 * udpate sourcekitten call to use symlink since platform stanze changed between 5.0 and 5.2 * update sourcekitten argument to match the new version
@tomerd
Copy link
ContributorAuthor

tomerd commented Jan 22, 2021

alternatively we can change the script to pin to the older version

@Lukasa@weissi probably need to check nio as well

cc @ktoso@yim-lee

@ktoso
Copy link
Contributor

Uff yeah, I may have hit this before 🤔
Will check in other repos

Copy link
Contributor

@weissiweissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@weissi
Copy link
Contributor

alternatively we can change the script to pin to the older version

@Lukasa@weissi probably need to check nio as well

@tomerd NIO seems okay, last release is 2.25.1 and the docs are for that very release.

@tomerd
Copy link
ContributorAuthor

alternatively we can change the script to pin to the older version

@Lukasa@weissi probably need to check nio as well

@tomerd NIO seems okay, last release is 2.25.1 and the docs are for that very release.

looking at the code i think its susceptible to the same issue. it likely using a cached version which is why have not surfaced yet

@tomerdtomerd merged commit bbebce3 into swift-server:mainJan 24, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs are wildly out of date

3 participants

@tomerd@ktoso@weissi