Skip to content

Conversation

@artemredkin
Copy link
Collaborator

Since we don't have a connection pool, we need to close channel after request is processed, this PR addresses #33

Copy link
Contributor

@weissiweissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (until we get the connection pool; CC @adtrevor)

@weissi
Copy link
Contributor

weissi commented May 14, 2019

@artemredkin tests failed:

Test Case 'SwiftHTTPTests.testHTTPPartsHandler' started at 2019-05-14 16:04:08.514 /code/Tests/NIOHTTPClientTests/SwiftNIOHTTPTests.swift:58: error: SwiftHTTPTests.testHTTPPartsHandler : XCTAssertEqual failed: ("head(HTTPRequestHead{method: GET, uri: "/get", version: HTTP/1.1, headers: [("X-Test-Header", "X-Test-Value"), ("Host", "localhost"), ("Content-Length", "4")] })") is not equal to ("head(HTTPRequestHead{method: GET, uri: "/get", version: HTTP/1.1, headers: [("X-Test-Header", "X-Test-Value"), ("Host", "localhost"), ("Connection", "close"), ("Content-Length", "4")] })") - Test Case 'SwiftHTTPTests.testHTTPPartsHandler' failed (0.002 seconds) 

expected is missing the connection: close header

@artemredkin
Copy link
CollaboratorAuthor

Test fixed

@artemredkinartemredkin merged commit 317f4fa into masterMay 15, 2019
@artemredkinartemredkin deleted the fix_leaking_connections branch May 15, 2019 09:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@artemredkin@weissi