Make DelayOnHeadDelegate resilient#374
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently the DelayOnHeadDelegate test utility depends on correct timings. Right now, if a request is slower than 50ms in `testErrorAfterCloseWhileBackpressureExerted` the test will fail, since the backpressure promise is failed, before a head was received. This pr fixes this, by giving the user a callback, when the head was received.
fabianfettforce-pushed the ff-fix-test-that-rely-on-timing branch from 6986d18 to 735e09bCompare
Davidde94 approved these changes Jun 16, 2021
fabianfett changed the title 
MemberAuthor
fabianfett commented Jun 16, 2021
@swift-server-bot test this please |
Lukasa approved these changes Jun 16, 2021
MemberAuthor
fabianfett commented Jun 16, 2021
@Lukasa I just noticed: This only changes test code, but got |
Collaborator
Lukasa commented Jun 17, 2021
Sure. I used patch version only because I was too lazy to create the label. 😉 |
fabianfett added semver/none Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
DelayOnHeadDelegatetest utility depends on correct timings. Right now, if a request is slower than 50ms intestErrorAfterCloseWhileBackpressureExertedthe test will fail, since the backpressure promise is failed, before a head was received. This pr fixes this, by giving the user a callback, when the head was received.