Fix CI for Swift 5.3#408
Merged
Fix CI for Swift 5.3 #408
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
glbrntt reviewed Aug 19, 2021
Collaborator
glbrntt left a comment
glbrntt left a comment There was a problem hiding this comment.
Does AHC actually build + publish docs?
MemberAuthor
last version is https://swift-server.github.io/async-http-client/docs/current/AsyncHTTPClient/index.html |
Collaborator
glbrntt commented Aug 19, 2021
Ah, cool, I didn't realise we published them at some point. I guess @tomerd will have some insight on why the last version is 1.2.3. |
glbrntt approved these changes Aug 19, 2021
Collaborator
glbrntt left a comment
glbrntt left a comment There was a problem hiding this comment.
Looks fine for now but maybe the ruby version should be updated and the jazzy version unpinned.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Swift 5.3 CI currently fails with the error:
Example log: https://ci.swiftserver.group/job/async-http-client-swift53-prb/338/console
Changes
Result
Happy Swift 5.3 CI