Ensure the HTTPConnectionPool calls shutdown on active connections.#422
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fabianfett requested review from Lukasa and glbrntt and removed request for glbrntt
Lukasa approved these changes Sep 13, 2021
MemberAuthor
fabianfett commented Sep 13, 2021
@swift-server-bot test this please |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently active connections are just closed on shutdown. We expect running requests to be cancelled though.
Changes
HTTPConnectionPool.Connectionto cancel the request and close the connection thenResult
A better behaving http client.