Skip to content

Fix HTTP/1.0 support#431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabianfett merged 3 commits into from
Sep 20, 2021
Merged

Fix HTTP/1.0 support #431

fabianfett merged 3 commits into from
Sep 20, 2021

Conversation

@fabianfett
Copy link
Member

@fabianfettfabianfett commented Sep 20, 2021

Motivation

Currently we don't close connections if we receive an HTTP/1.0 response but no keep-alive header.

Changes

  • Use HTTPResponseHead.isKeepAlive instead of relying on our own test
  • Add tests

Result

Happy HTTP/1.0 communication.

@fabianfettfabianfett added the 🔨 semver/patch No public API change. label Sep 20, 2021
@fabianfettfabianfett added this to the HTTP/2 support milestone Sep 20, 2021
Lukasa
Lukasa approved these changes Sep 20, 2021
View reviewed changes
Copy link
Collaborator

@LukasaLukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM.

@fabianfettfabianfett merged commit b25943a into swift-server:mainSep 20, 2021
@fabianfettfabianfett deleted the ff-http-1.0 branch September 20, 2021 16:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukasaLukasaLukasa approved these changes

@dnadobadnadobaAwaiting requested review from dnadoba

Assignees

No one assigned

Labels

🔨 semver/patchNo public API change.

Projects

None yet

Milestone

HTTP/2 support

Development

Successfully merging this pull request may close these issues.

2 participants

@fabianfett@Lukasa