[HTTPConnectionPool] Fix timer action races#434
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fabianfett changed the title fabianfettforce-pushed the ff-fix-lock-problems branch from 562b6a0 to 3b6ed79Compare
[HTTPConnectionPool] Add HTTP/1.1 stress test
fabianfettforce-pushed the ff-fix-lock-problems branch from 3b6ed79 to 3e77f65CompareSign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We have a race between some actions created in the state machine under the
stateLockand their implementation in theHTTPConnectionPool.Changes
_idleTimerand_backoffTimerare protected bystateLockstruct Actionsthat splits up actions from the state machine into actions that need to be executed inside thestateLockand outside instateLockResult
No more races in timer scheduling.