Skip to content

[RequestBag] Fix consumption error in state machine#441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabianfett merged 1 commit into from
Sep 27, 2021
Merged

[RequestBag] Fix consumption error in state machine #441

fabianfett merged 1 commit into from
Sep 27, 2021

Conversation

@fabianfett
Copy link
Member

@fabianfettfabianfett commented Sep 27, 2021

Motivation

If a RequestBag was consuming received http body parts in its HTTPClientResponseDelegate in the didReceiveBodyPart and received a succeedRequest, the didFinishRequest was called before the didReceiveBodyPart future was resolved.

Changes

  • Call didFinishRequest only once the didReceiveBodyPart future was succeeded.

Result

@fabianfettfabianfett added the 🔨 semver/patch No public API change. label Sep 27, 2021
@fabianfettfabianfett added this to the HTTP/2 support milestone Sep 27, 2021
@fabianfettfabianfett mentioned this pull request Sep 27, 2021
Merged
@fabianfett
Copy link
MemberAuthor

fabianfett commented Sep 27, 2021

swift-nightly fails because of Sendable requirements.

@fabianfettfabianfett merged commit 316cbf9 into swift-server:mainSep 27, 2021
@fabianfettfabianfett deleted the ff-fix-race-condition-on-close branch September 27, 2021 13:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukasaLukasaLukasa approved these changes

Assignees

No one assigned

Labels

🔨 semver/patchNo public API change.

Projects

None yet

Milestone

HTTP/2 support

Development

Successfully merging this pull request may close these issues.

2 participants

@fabianfett@Lukasa