Skip to content

Conversation

@fabianfett
Copy link
Member

@fabianfettfabianfett commented Sep 28, 2021

Motivation

After the release of 1.6.0, we can now remove the deprecated connection pool.

Changes

  • Remove now unused Connection/ConnectionPool
  • Removed TaskHandler
  • Remove ResponseReadBuffer
  • Remove unused imports

Result

Less code to maintain.

@fabianfett
Copy link
MemberAuthor

fabianfett commented Sep 28, 2021

Open tasks

  • Need to remove test util: RecordingHandler

@fabianfettfabianfettforce-pushed the ff-remove-deprecated-connection-pool branch from f7315d7 to ad759ccCompareSeptember 29, 2021 10:20
@fabianfettfabianfett added the 🔨 semver/patch No public API change. label Sep 29, 2021
@fabianfettfabianfett added this to the HTTP/2 support milestone Sep 29, 2021
@fabianfettfabianfett changed the title [Draft] Remove deprecated connection poolRemove deprecated connection poolSep 29, 2021
@fabianfettfabianfett marked this pull request as ready for review September 29, 2021 11:21
@fabianfett
Copy link
MemberAuthor

Failing swift-nightly ci because of Sendable requirements.

@fabianfettfabianfett merged commit 2bd8885 into swift-server:mainSep 29, 2021
@fabianfettfabianfett deleted the ff-remove-deprecated-connection-pool branch September 29, 2021 16:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 semver/patchNo public API change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@fabianfett@glbrntt