Make sure that event loop of task is the same as event loop of channel#55
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
swift-server-bot commented Jun 27, 2019
Can one of the admins verify this patch? |
Collaborator
artemredkin commented Jun 27, 2019
@swift-server-bot test this please |
artemredkin approved these changes Jun 27, 2019
Collaborator
artemredkin commented Jun 27, 2019
@t089 thanks for the patch! could you update |
ContributorAuthor
t089 commented Jul 1, 2019
@artemredkin I ran |
Collaborator
artemredkin commented Jul 1, 2019
@swift-server-bot test this please |
Contributor
weissi commented Jul 3, 2019
@t089 sorry, there are conflicts now. We can merge this when they're fixed. |
ContributorAuthor
t089 commented Jul 3, 2019
Thanks. Rebased on master. |
Contributor
weissi commented Jul 3, 2019
wow that was quick, thanks so much @t089 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #54, currently if using a shared event loop group object to create a
HTTPClient, theeventLoopproperty of theChannelwill most likely not be the same as theeventLoopproperty of theTask. This can lead to a precondition failure, when the task delegate hops to the the task`s event loop.This patch makes sure that both the task and the connection (channel) share the same event loop instance.
It also add a precondition on
Task.setChannel(_:)to verify that the channel uses the same event loop as the task.The provided test would trigger the
preconditionfailure if the event loops would not match.