Skip to content

Speedup tests#639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnadoba merged 4 commits into from
Oct 11, 2022
Merged

Speedup tests #639

dnadoba merged 4 commits into from
Oct 11, 2022

Conversation

@dnadoba
Copy link
Collaborator

@dnadobadnadoba commented Oct 10, 2022•
edited
Loading

Motiviation

We like fast tests.

Modification

  • set networkFrameworkWaitForConnectivity and connectionPool.retryConnectionEstablishment to false for most test cases
  • move long running test cases into separate classes so they can run in parallel

Results

ModeOldNewRelative
Serial180s (3m 0s)48s3.75x
Parallel62s (1m 2s)12s5.1x

@dnadobadnadoba added the semver/none No version bump required. label Oct 10, 2022
@dnadobadnadoba marked this pull request as ready for review October 11, 2022 10:27
FranzBusch
FranzBusch approved these changes Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@FranzBuschFranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff! Looks good to me!

@dnadobadnadoba merged commit 9195d3b into swift-server:mainOct 11, 2022
@dnadobadnadoba deleted the dn-speedup-tests branch October 11, 2022 15:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FranzBuschFranzBuschFranzBusch approved these changes

Assignees

No one assigned

Labels

semver/noneNo version bump required.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dnadoba@FranzBusch