Skip to content

Conversation

@glbrntt
Copy link
Collaborator

Motivation:

The body stream writer can be sent across isolation domains so should be sendable.

Modifications:

  • Make it explicitly sendable
  • Add appropriate preconcurrency annotations
  • Wrap an iterator from swift-algorithms as it hasn't yet annotated its types with Sendable

Result:

Body stream writer is sendable

Motivation: The body stream writer can be sent across isolation domains so should be sendable. Modifications: - Make it explicitly sendable - Add appropriate preconcurrency annotations - Wrap an iterator from swift-algorithms as it hasn't yet annotated its types with Sendable Result: Body stream writer is sendable
@glbrnttglbrntt added the 🆕 semver/minor Adds new public API. label Apr 29, 2025
@glbrntt
Copy link
CollaboratorAuthor

This is expected:

1 breaking change detected in AsyncHTTPClient: 💔 API breakage: constructor HTTPClient.Body.StreamWriter.init(closure:) is now with @preconcurrency 

@LukasaLukasa merged commit a4fcd70 into swift-server:mainApr 29, 2025
22 of 24 checks passed
@glbrnttglbrntt deleted the strict-stream-writer branch April 29, 2025 14:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🆕 semver/minorAdds new public API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@glbrntt@Lukasa