Remove CollectEverythingLogHandler implementation in favour of InMemoryLogHandler from swift-log#874
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hamzahrmalik changed the title 
hamzahrmalikforce-pushed the use_new_in_memory_logger branch from f3c086f to 1c405c2Compare
glbrntt approved these changes Dec 4, 2025
glbrntt merged commit 5dd84c7 into swift-server:main 61 of 62 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swift log now has an InMemoryLogHandler. Lets depend on that instead of having our own
CollectEverythingLogHandler.I've added an extension on top, to make it easier to create the logger too
Result: less code