Include child diagnostics with source locations for missing header dependencies#859
+63 −16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…pendencies The updated Clang "print-headers-direct-per-file" tracing feature includes source locations. Missing header diagnostics should include child diagnostics to show the locations of those includes. rdar://162322751
ContributorAuthor
bob-wilson commented Oct 20, 2025
I think this change is ready except that it requires removing the "fake" feature flag for "print-headers-direct-per-file" (rdar://161741746), so that we actually enable this only when Clang supports the updated tracing. |
owenv approved these changes Oct 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updated Clang "print-headers-direct-per-file" tracing feature includes source locations. Missing header diagnostics should include child diagnostics to show the locations of those includes.
rdar://162322751