Skip to content

Fix CaseDetectionMacro to handle multiple elements and improve casing#3061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Stof83 wants to merge 1 commit into
base:main
Choose a base branch
from
Open

Fix CaseDetectionMacro to handle multiple elements and improve casing #3061

Stof83 wants to merge 1 commit into from

Conversation

@Stof83
Copy link

@Stof83Stof83 commented Apr 19, 2025

This patch fixes a bug in CaseDetectionMacro where only the first case element was considered. It now handles multiple case elements and uses proper PascalCase formatting for isX computed properties.

ahoppen
ahoppen reviewed Apr 22, 2025
View reviewed changes
Copy link
Member

@ahoppenahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement. I have left a couple suggestion inline.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahoppenahoppenahoppen left review comments

@bnbarhambnbarhamAwaiting requested review from bnbarham

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Stof83@ahoppen