Acquiring GIL in pywrapper.cpp#153
Open
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
ShikharJ commented Jun 11, 2017
@isuruf@sumith1896 I'm not sure whether these are the expected changes. Can you please take a look and suggest improvements? |
MemberAuthor
ShikharJ commented Jun 14, 2017
Ping @isuruf@sumith1896 . |
isuruf reviewed Jun 14, 2017
symengine/lib/pywrapper.cpp Outdated
| namespaceSymEngine{ | ||
| #if PY_MAJOR_VERSION >= 3 | ||
| if (!PyGILState_Check()){ |
Member
There was a problem hiding this comment.
You can run code only inside a function. This is outside any function.
MemberAuthor
ShikharJ commented Aug 7, 2017
@isuruf Any suggestion what can be done here? |
MemberAuthor
ShikharJ commented Sep 2, 2017
@isuruf I'd like to get all my PRs merged, as soon as possible. Can you tell me if anything can be done here? |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant: #61