Skip to content

Update constants for systemd 258#157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
behrmann merged 3 commits into from
Oct 14, 2025
Merged

Update constants for systemd 258 #157

behrmann merged 3 commits into from
Oct 14, 2025

Conversation

@keszybz
Copy link
Member

@keszybzkeszybz commented Oct 3, 2025

No description provided.

github-advanced-security[bot]
github-advanced-securitybot found potential problems Oct 3, 2025
View reviewed changes
behrmann
behrmann reviewed Oct 4, 2025
View reviewed changes
Copy link
Contributor

@behrmannbehrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changing the sed stuff to Python makes it a lot more readable.

behrmann
behrmann reviewed Oct 4, 2025
View reviewed changes
src/systemd/meson.build

include_dir = libsystemd_dep.get_variable(pkgconfig: 'includedir')

update_constants =custom_target(
Copy link
Contributor

@behrmannbehrmannOct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having bashed my head against meson for a bit now, shouldn't this be a run_target instead?

Copy link
MemberAuthor

@keszybzkeszybzOct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno. I copied from the systemd config, update-man-rules target.

@keszybz
meson: hook up update-constants helper
7704ae0
$ ninja -C build update-constants -v ninja: Entering directory `build' [1/1] /home/zbyszek/src/python-systemd/update-constants.py /home/zbyszek/src/python-systemd/src/systemd/id128-constants.h /home/zbyszek/src/python-systemd/docs/id128.rst /home/zbyszek/src/python-systemd/src/systemd/id128-defines.h /usr/include/systemd/sd-messages.h Writing /home/zbyszek/src/python-systemd/src/systemd/id128-constants.h… Writing /home/zbyszek/src/python-systemd/src/systemd/id128-defines.h… Writing /home/zbyszek/src/python-systemd/docs/id128.rst… The helper is updated to do the everything in the python script. The wrapper in Makefile is dropped. It wasn't working properly anyway, and I think the version in meson is enough.
@keszybz
id128: update constants for systemd 258
1e29ed1
The previous commit changes the sorting algorithm, so a few lines moved up or down a bit.
@keszybz
Copy link
MemberAuthor

keszybz commented Oct 14, 2025

@behrmann do you want to take another look? If not, I think I'll merge this and the other PR (#160).

@behrmannbehrmann merged commit 6396126 into systemd:mainOct 14, 2025
17 checks passed
@keszybzkeszybz deleted the update-constants branch October 21, 2025 14:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behrmannbehrmannbehrmann approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@keszybz@behrmann