Skip to content

Conversation

@ltiffanydev
Copy link
Collaborator

Added support for Data Acceleration and Data Freshness Policy REST API.
Mainly adding functionalities to workbook.update & workbook.get_by_id

@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Lucky Tiffany <l***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

@bcantoni
Copy link
Contributor

bcantoni commented Jan 17, 2024

@ltiffanydev I closed & reopened this PR to force the CLA bot to run again and it looks happy now.

One change you'll need to make on this PR is target it for the development branch instead of master.

Also, the style and mypy checks are failing; see the developer guide for getting those cleaned up on your branch.

@ltiffanydevltiffanydev changed the base branch from master to developmentJanuary 17, 2024 19:57
jacalata
jacalata previously requested changes Jan 17, 2024
@github-actions
Copy link

github-actionsbot commented Jan 17, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
tableauserverclient
__init__.py40100%
_version.py279163163 42%
config.py50100%
datetime_helpers.py2511 96%
exponential_backoff.py200100%
filesys_helpers.py310100%
namespace.py2633 88%
tableauserverclient/helpers
__init__.py10100%
headers.py1388 38%
logging.py20100%
strings.py2711 96%
tableauserverclient/models
__init__.py370100%
column_item.py553232 42%
connection_credentials.py351111 69%
connection_item.py771010 87%
custom_view_item.py11999 92%
data_acceleration_report_item.py5411 98%
data_alert_item.py15933 98%
data_freshness_policy_item.py1561515 90%
database_item.py2033434 83%
datasource_item.py2401111 95%
dqw_item.py10455 95%
exceptions.py40100%
favorites_item.py5788 86%
fileupload_item.py190100%
flow_item.py1491010 93%
flow_run_item.py720100%
group_item.py8133 96%
interval_item.py1833434 81%
job_item.py1771212 93%
metric_item.py1301212 91%
pagination_item.py340100%
permissions_item.py7577 91%
project_item.py1443131 78%
property_decorators.py991818 82%
reference_item.py190100%
revision_item.py6033 95%
schedule_item.py20666 97%
server_info_item.py3955 87%
site_item.py6101212 98%
subscription_item.py10333 97%
table_item.py1181818 85%
tableau_auth.py712626 63%
tableau_types.py2311 96%
tag_item.py160100%
target.py60100%
task_item.py5722 96%
user_item.py2771717 94%
view_item.py1781515 92%
webhook_item.py660100%
workbook_item.py2751616 94%
tableauserverclient/server
__init__.py80100%
exceptions.py40100%
filter.py2111 95%
pager.py3744 89%
query.py1092121 81%
request_factory.py941136136 86%
request_options.py26044 98%
server.py1631717 90%
sort.py60100%
tableauserverclient/server/endpoint
__init__.py270100%
auth_endpoint.py761212 84%
custom_views_endpoint.py6822 97%
data_acceleration_report_endpoint.py210100%
data_alert_endpoint.py972525 74%
databases_endpoint.py1033333 68%
datasources_endpoint.py3084141 87%
default_permissions_endpoint.py4655 89%
dqw_endpoint.py431616 63%
endpoint.py1671616 90%
exceptions.py6066 90%
favorites_endpoint.py952222 77%
fileuploads_endpoint.py510100%
flow_runs_endpoint.py631010 84%
flows_endpoint.py2176060 72%
groups_endpoint.py1071111 90%
jobs_endpoint.py5888 86%
metadata_endpoint.py881414 84%
metrics_endpoint.py5888 86%
permissions_endpoint.py4655 89%
projects_endpoint.py1272222 83%
resource_tagger.py401010 75%
schedules_endpoint.py1001111 89%
server_info_endpoint.py351010 71%
sites_endpoint.py1262828 78%
subscriptions_endpoint.py581515 74%
tables_endpoint.py1023939 62%
tasks_endpoint.py6577 89%
users_endpoint.py1271515 88%
views_endpoint.py1241010 92%
webhooks_endpoint.py571111 81%
workbooks_endpoint.py3354242 87%
TOTAL9664126387%

@ltiffanydevltiffanydev dismissed jacalata’s stale reviewMarch 4, 2024 22:33

Have applied all the feedbacks and clarified the question on versioning

@bcantoni
Copy link
Contributor

@ltiffanydev reminder when you merge this to use the "squash and merge" option to bring all these commits into one. I think that might be the default anyways.

Also, you can ignore the failing License Compliance check. It's happening to all PRs on TSC at the moment.

@ltiffanydevltiffanydev merged commit eaedc29 into developmentMar 5, 2024
@ltiffanydevltiffanydev deleted the add_data_acceleration_and_data_freshness_policy_support branch March 5, 2024 06:21
bcantoni added a commit that referenced this pull request Jun 3, 2024
* Changes to alter cgi dependency to email.Messages * Changes to alter cgi dependency to email.Messages * Changes to alter cgi dependency to email.Messages * Changes to alter cgi dependency to email.Messages * feat: allow viz height and width parameters * fix: use python3.8 syntax * fix: python3.8 syntax * docs: comment PDF viz dimensions XOR * Add support for System schedule type I'm not fully clear on where these might come from, but this change should let TSC work in such cases. Fixes#1349 * Add failing test retrieving a task with 24 hour (aka daily) interval * Add 24 (hours) as a valid interval which can be returned from the server * Add Python 3.12 to test matrix * Tweak test action to stop double-running everything * feat: add description support on wb publish * Add Data Acceleration and Data Freshness Policy support (#1343) * Add data acceleration & data freshness policy functions * Add unit tests and raise errors on missing params * fix types & spell checks * addressed some feedback * addressed feedback * cleanup code * Revert "Merge branch 'add_data_acceleration_and_data_freshness_policy_support' of https://github.com/tableau/server-client-python into add_data_acceleration_and_data_freshness_policy_support" This reverts commit 5b30e57, reversing changes made to 5789e32. * fix formatting * Address feedback * mypy & formatting changes * Improve robustness of Pager results In some cases, Tableau Server might have a different between the advertised total number of object and the actual number returned via the Pager. This change adds one more check to prevent errors from happening in these situations. Fixes#1304 * Add Cloud Flow Task endpoint * cleanup * black format * add xml * edit test initialization * fix task initialization * third times the charm * cleanup * fix formatting * feat: pass parameters in request options * chore: pin typing_extensions version --------- Co-authored-by: markm <[email protected]> Co-authored-by: Mark Moreno <[email protected]> Co-authored-by: Jordan Woods <[email protected]> Co-authored-by: Brian Cantoni <[email protected]> Co-authored-by: Brian Cantoni <[email protected]> Co-authored-by: ltiffanydev <[email protected]> Co-authored-by: liu.r <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ltiffanydev@bcantoni@jacalata