feat: tag everything#1422
Merged
feat: tag everything #1422
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
jorwoods commented Jul 23, 2024
Since workbooks, views, and data sources all follow the same pattern here, theoretically we could solve this with a Mixin class and add the functionality to all three with reduced duplication. |
jorwoodsforce-pushed the jorwoods/wb_tags branch 2 times, most recently from dbbe005 to 3759248CompareContributorAuthor
jorwoods commented Jul 30, 2024
Virtual connections also follow this pattern and could have the functionality added via a mixin class if that's the route we want to go. |
Contributor
jacalata commented Aug 2, 2024
yes, I think that's a great idea. I'd love to get all the shared functionality actually extracted from individual objects in this code. |
jorwoodsforce-pushed the jorwoods/wb_tags branch 2 times, most recently from f7b510e to 095df29Comparejorwoods changed the title 
ContributorAuthor
After this gets merged, I can rebase #1429 and add tagging support for virtual connections as well. |
This reverts commit a3c9afa. api decorator is masking some problems with mypy, and needs a more in depth investigation than belongs in this branch
jacalata approved these changes Aug 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#1421