chore: typing decorators#1447
Merged
chore: typing decorators #1447
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jorwoodsforce-pushed the jorwoods/typing_decorators branch from a80b505 to 9f7bfaaComparejorwoodsforce-pushed the jorwoods/typing_decorators branch from f1f8fcf to a5f1018Comparejorwoodsforce-pushed the jorwoods/typing_decorators branch from a5f1018 to 99d330fCompare Merged
jacalata added a commit that referenced this pull request Sep 17, 2024
v0.33 Features: - add name, datasource-name to Job item - enable bulk add and remove users - Linked Tasks: get, get by ID, run Now - implement Tags: create new, add/delete for workbooks, flows, datasources - get page and chunk size from env vars - add some repr implementations - implement virtual connections Bugfix: - #1447 - #1449
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decorators like
api,parameter_added_in, and_tsrequest_wrappedaltered the typing signatures and obfuscated mypy from inspecting any of the functions wrapped by these decorators. This PR aims to type these decorators, and fix any underlying typing issues revealed by fixing this.