Update google.py to remove the native word#2394
Open
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
A lot of Gemini models are native image out or native audio, so this rule was raising too many false positives.
markmcd reviewed Sep 8, 2025
Member
markmcd left a comment
markmcd left a comment There was a problem hiding this comment.
Can this go in the Gemini cookbook styles? the change doesn't seem Google-wide.
ContributorAuthor
Giom-V commented Sep 8, 2025
It can't, they are not the same thing. We're applying both styles at the moment... I could merge both into one, but that's way more work and I thought that we were the only ones using this script anyway... |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of Gemini models are native image out or native audio, so this rule was raising too many false positives.