fix(kafka): Use wait strategy instead of deprecated wait_for_logs#903
+12 −7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #903 +/- ## ========================================== - Coverage 79.78% 79.52% -0.26% ========================================== Files 14 14 Lines 1182 1182 Branches 184 184 ========================================== - Hits 943 940 -3 - Misses 197 201 +4 + Partials 42 41 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hugo-C changed the title Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #874.
Since those containers first need to be started to know their exposed ports, we cannot use
DockerContainer._wait_strategy. We have to keep checking logs manually in their ownstartmethods.Let me know if there is anything to change.