feat: add warnings when globals are missing#1244
Merged
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Adds a warning when we weren't able to setup logic through test runner globals (
afterEach,beforeAll,afterAll).Why: This was raised in #1240 and I believe it's worth adding because some stuff won't work for users so they should have a warning stating why.
How:
Adding
elseblocks in the relevant places.Checklist:
[ ] Documentation added to thedocs site
TestsTypeScript definitions updated