Skip to content

Conversation

@MatanBobi
Copy link
Member

What: Resolves#1249

Why: To prevent the warning from being logged in every test suite.

How:

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • TypeScript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6cf623e:

SandboxSource
ReactConfiguration
react-testing-library-examplesConfiguration

@codecov
Copy link

codecovbot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d80319f) 100.00% compared to head (6cf623e) 100.00%.

Additional details and impacted files
@@ Coverage Diff @@## main #1252 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 4 4 Lines 192 192 Branches 40 40 ========================================= Hits 192 192 
FlagCoverage Δ
canary100.00% <ø> (ø)
experimental100.00% <ø> (ø)
latest100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@timdeschryvertimdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timdeschryvertimdeschryver merged commit fd52a59 into mainNov 17, 2023
@timdeschryvertimdeschryver deleted the fix/log-warning-once branch November 17, 2023 14:46
@AviVahl
Copy link

@MatanBobi
this caused a ReferenceError: process is not defined in our browser tests.
please note that typeof process === 'undefined' also goes into that if block.

@MatanBobi
Copy link
MemberAuthor

@AviVahl - Sorry about that, totally missed it.
I'll issue a fix soon :)

@MatanBobiMatanBobi mentioned this pull request Nov 17, 2023
4 tasks
@MatanBobi
Copy link
MemberAuthor

This change was reverted :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide a better experience with lifecycle hooks

4 participants

@MatanBobi@AviVahl@timdeschryver