fibonacciNth function added#36
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@## master #36 +/- ## ===================================== Coverage 100% 100% ===================================== Files 81 82 +1 Lines 1799 1809 +10 Branches 318 319 +1 ===================================== + Hits 1799 1809 +10
Continue to review full report at Codecov.
|
a-b commented Jun 1, 2018
The bottom-up approach looks fine, it would be great to add test ensuring expected time complexity. |
Owner
trekhleb commented Jun 2, 2018
@ohepworthbell thank you for cleaning the code up and for clean implementation of new function! |
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fibonacci()function now returns array of the fibonacci sequence, with the functionfibonacciNth()returning the value at nth-position in the fibonacci sequence.