Skip to content

fix(ui): respect rootOnlyDefault, disable adjacent run navigation in inspector views#2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0ski merged 2 commits into from
Dec 12, 2025
Merged

fix(ui): respect rootOnlyDefault, disable adjacent run navigation in inspector views #2781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3874b4
fix(ui): respect rootOnlyDefault, disable adjacent run navigation in …
0ski Dec 12, 2025
44e9f88
chore(webapp): Add a comment to stop code rabbit from going rabid
0ski Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion apps/webapp/app/components/runs/v3/TaskRunsTable.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,23 +56,28 @@ import{
TaskRunStatusCombo,
} from "./TaskRunStatus"
import{useOptimisticLocation } from "~/hooks/useOptimisticLocation"
import{useSearchParams } from "~/hooks/useSearchParam"

type RunsTableProps ={
total: number;
hasFilters: boolean;
filters: NextRunListAppliedFilters;
showJob?: boolean;
runs: NextRunListItem[];
rootOnlyDefault?: boolean;
isLoading?: boolean;
allowSelection?: boolean;
variant?: TableVariant;
disableAdjacentRows?: boolean;
};

export function TaskRunsTable({
total,
hasFilters,
filters,
runs,
rootOnlyDefault,
disableAdjacentRows = false,
isLoading = false,
allowSelection = false,
variant = "dimmed",
Expand All@@ -82,8 +87,12 @@ export function TaskRunsTable({
const checkboxes = useRef<(HTMLInputElement | null)[]>([]);
const{has, hasAll, select, deselect, toggle } = useSelectedItems(allowSelection);
const{isManagedCloud } = useFeatures();
const{value } = useSearchParams();
const location = useOptimisticLocation();
const tableStateParam = encodeURIComponent(location.search ? `${location.search}&rt=1` : "rt=1");
const rootOnly = value("rootOnly") ? `` : `rootOnly=${rootOnlyDefault}`;
const search = rootOnly ? `${rootOnly}&${location.search}` : location.search;
/** TableState has to be encoded as a separate URI component, so it's merged under one, 'tableState' param */
const tableStateParam = disableAdjacentRows ? '' : encodeURIComponent(search);

const showCompute = isManagedCloud;

Expand Down
1 change: 1 addition & 0 deletions ...es/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs._index/route.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -298,6 +298,7 @@ function RunsList({
runs={list.runs}
isLoading={isLoading}
allowSelection
rootOnlyDefault={rootOnlyDefault}
/>
</div>
)}
Expand Down
1 change: 1 addition & 0 deletions ...$organizationSlug.projects.$projectParam.env.$envParam.schedules.$scheduleParam/route.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -318,6 +318,7 @@ export default function Page(){
runs={schedule.runs}
isLoading={false}
variant="bright"
disableAdjacentRows
/>
</div>
<div className="flex flex-col gap-1 pt-2">
Expand Down
1 change: 1 addition & 0 deletions ...tionSlug.projects.$projectParam.env.$envParam.waitpoints.tokens.$waitpointParam/route.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,7 @@ export default function Page(){
runs={waitpoint.connectedRuns}
isLoading={false}
variant="bright"
disableAdjacentRows
/>
</div>
</div>
Expand Down