Skip to content

Get item links#16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
halloju wants to merge 5 commits into
base:master
Choose a base branch
from
Open

Get item links #16

halloju wants to merge 5 commits into from
+130 −7

Conversation

@halloju
Copy link
Contributor

@hallojuhalloju commented Oct 29, 2021

issue 7

@hrchu
Copy link
Member

hrchu commented Nov 1, 2021

This branch has conflicts that must be resolved.

hrchu
hrchu reviewed Nov 2, 2021
View reviewed changes
@hrchuhrchu mentioned this pull request Nov 2, 2021
Open
hrchu
hrchu reviewed Nov 2, 2021
View reviewed changes
hrchu
hrchu reviewed Nov 10, 2021
View reviewed changes
src/solid/utils/api_util.py
defare_files(urls: List) ->bool:
pass

defget_links_from_response(response) ->dict:
Copy link
Member

@hrchuhrchuNov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> Dict

src/solid/utils/api_util.py
else:
returnparse_link_header(link_header, response.url)

defparse_link_header(link_header: str, item_url) ->Dict:
Copy link
Member

@hrchuhrchuNov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you prefer a Dict instead of Links here?

@hrchu
Copy link
Member

hrchu commented Nov 10, 2021•
edited
Loading

@halloju What server implementation do you test against?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hrchuhrchuhrchu left review comments

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@halloju@hrchu