Skip to content

Conversation

@koka831
Copy link
Contributor

Ref: #18
This is the enhancement to separate classname from function name.
about regexp of pythonClassName, I intend to make it compliant with pep.

@nfnty
Copy link
Member

Thanks, waiting for the improved regex.

@koka831
Copy link
ContributorAuthor

now I created g:python_highlight_class_names highlight option, which is enable by default.
and add some testcases to make sure class name starts with Capital.
review me again, please.

@terminalnode
Copy link

Layman here so I don't think I'm qualified to leave an actual review, but I tried this and it works well for me.

I changed the color to Special because that works better in my theme, but everything seems to work as expected.

@richin13
Copy link

Works great, @nfnty any specific reason to not merge this?

@koka831
Copy link
ContributorAuthor

@nfnty may I ask you, what do you mean by

the improved regex

If this PR don't work as expected, I'll fix it.

@ckudera
Copy link

Any updates on this PR? Works fine for me.

@nfntynfnty closed this in 83d4c63Dec 2, 2020
@nfnty
Copy link
Member

nfnty commented Dec 2, 2020

Thanks!

cdonovick pushed a commit to cdonovick/python-syntax that referenced this pull request Apr 16, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@koka831@nfnty@terminalnode@richin13@ckudera