Add some style#5
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
wildskyf commented Jun 29, 2016
wildskyf commented - Use variable for style
- Add style of selection
- Add status bar
Which allow us change style easily in the future
MemberAuthor
wildskyf commented Jun 29, 2016
@chusiang 看一下，如果覺得沒問題的話就 merge 吧～ |
Member
@wildskyf 您應該有權限自己 merge 吧？我手邊沒有現成的 Jekyll 環境，要晚點才有剛看喔。:P |
Member
chusiang commented Jun 30, 2016
翻了一下之前寫的 README，在 style branch 看到底下多了底 status bar，真是好漂亮啊！
|
MemberAuthor
wildskyf commented Jun 30, 2016
@chusiang 有權限是有權限，但我想讓前輩 code review 一下 XD 看來下一次發 PR 的時候要順便加上截圖好像比較方便！ |
Member
chusiang commented Jul 1, 2016
@wildskyf 還好啦，有寫 README 跟 Makefile 我就可以很快的進入 n 個月前的專案。:P |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.