feat(runtime-core): set currentInstance during hook execution for custom directives(close: #5002)#5036
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets
currentInstancebefore hook calls, unsets it afterwards.This allows for the following APIS to be used in custom directives:
getCurrentInstance()inject()provide()onUpdated()(not sure if this is a good idea)Alternatives
I'm not yet convinced that this is the best solution.
Specifically, I'm not sure if the breadth of "setup" APIs exposed to custom directives by this is really desirable, or if we should limit it to
provide/inject, for which we could expose special versions throughbinding()on the binding - i.e binding.inject()? That would require more new code to be introduced though.close: #5002