Skip to content

Conversation

@snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

  • Add examples for ipc option.
  • Rename web-server-socket -> web-socket-server

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecovbot commented Aug 18, 2021

Codecov Report

Merging #3667 (0110251) into master (f1fdaa7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #3667 +/- ## ======================================= Coverage 93.67% 93.67% ======================================= Files 15 15 Lines 1312 1312 Branches 451 451 ======================================= Hits 1229 1229 Misses 76 76 Partials 7 7 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1fdaa7...0110251. Read the comment docs.

Copy link
Member

@alexander-akaitalexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I agree we should union CLI and devServer options from webpack.config.js, I think we should move our example from cli directory and put them like examples/ipc, examples/host and etc

@snitin315
Copy link
MemberAuthor

Looks good, I agree we should union CLI and devServer options from webpack.config.js, I think we should move our example from cli directory and put them like examples/ipc, examples/host and etc

Yes, I will update 👍

@alexander-akaitalexander-akait merged commit 16fcdbc into masterAug 18, 2021
@alexander-akaitalexander-akait deleted the ipc-example branch August 18, 2021 11:07
@alexander-akait
Copy link
Member

Thanks

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@snitin315@alexander-akait