Skip to content

Update PyBind11 guard to 3.x release#324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JohanMabille merged 1 commit into from
Jul 31, 2025
Merged

Update PyBind11 guard to 3.x release #324

JohanMabille merged 1 commit into from
Jul 31, 2025

Conversation

@serge-sans-paille
Copy link
Contributor

@serge-sans-pailleserge-sans-paille commented Jul 31, 2025

Fix#323

@JohanMabille
Copy link
Member

JohanMabille commented Jul 31, 2025

I'm not sure this is enough to fix #323 though, we haven't tested xtensor-python with pybind11 3.

@serge-sans-paille
Copy link
ContributorAuthor

serge-sans-paille commented Jul 31, 2025

(I don't have merge right) At least it now builds ;-)

@serge-sans-paille
Copy link
ContributorAuthor

serge-sans-paille commented Jul 31, 2025

see https://src.fedoraproject.org/rpms/xtensor-python/pull-request/2 for a working build with pyBind11 v3

@JohanMabilleJohanMabille merged commit 680c6a4 into xtensor-stack:masterJul 31, 2025
12 checks passed
@JohanMabille
Copy link
Member

JohanMabille commented Jul 31, 2025

Thanks for the fix btw ;)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohanMabilleJohanMabilleJohanMabille approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for pybind11 3.0

2 participants

@serge-sans-paille@JohanMabille