fix: clear session token after logout#20
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly removing the session-token cookie and preventing refreshing it
Description
I found two problems regarding the
authjs.session-tokencookie:My proposed changes solve both of these problems
Related Issue
#18
Motivation and Context
Not removing session tokens after logout is a security flaw, as other users on the same machine could access protected sites / data even the original user logged out.
How Has This Been Tested?
I manually tested the behaviour on localhost and check with browser tools, that the cookie was properly removed.
Documentation:
None
Checklist: