Fix future issue in sock_connect()#389
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1st1 approved these changes Feb 8, 2021
Member
1st1 commented Feb 8, 2021
Can you see if there are any other sock* apis that check on fut.cancelled and not on fut.done? |
CPython fixed the same issue in python/cpython#10419. Seems like under pressure, more write callbacks may happen before _remove_writer() is called, so we should check for done(). FixesMagicStack#378
fantixforce-pushed the t378-fix-sock-connect branch from 1f8fdba to cd85662CompareMemberAuthor
fantix added a commit to fantix/uvloop that referenced this pull request Feb 9, 2021
Use _SyncSocketWriterFuture for cancellation, so that we could remove the writer directly in the callback. FixesMagicStack#378ClosesMagicStack#389
fantix added a commit to fantix/uvloop that referenced this pull request Feb 9, 2021
Use _SyncSocketWriterFuture for cancellation, so that we could remove the writer directly in the callback. FixesMagicStack#378ClosesMagicStack#389
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like, under pressure, more write callbacks may happen before
_remove_writer()is called, so we should check fordone()instead ofcancelled(). I could reproduce this reliably on Linux with @Catstyle's script, and this PR does fix the issue. I tried to hack in a test but it wasn't easy at all (somehow libuvuv_poll_tcould fire multiple times in a single event loop, while we're expectinguv_idle_tto step in immediately in the next loop to remove theuv_poll_t)