bpo-30064: Refactor sock_* asyncio API#10419
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
asvetlov changed the title 
ContributorAuthor
asvetlov commented Nov 8, 2018
@1st1 please review |
1st1 approved these changes Nov 12, 2018
Member
1st1 left a comment
1st1 left a comment There was a problem hiding this comment.
This is a nice step forward but we also need to start using socket._io_refs to prevent sockets from being removed during IO.
ContributorAuthor
asvetlov commented Nov 12, 2018
I'll do it in the following PR. |
bedevere-bot commented Nov 12, 2018
@asvetlov: Please replace |
fantix added a commit to fantix/uvloop that referenced this pull request Feb 8, 2021
CPython fixed the same issue in python/cpython#10419. Seems like under pressure, more write callbacks may happen before _remove_writer() is called, so we should check for done(). FixesMagicStack#378
fantix added a commit to fantix/uvloop that referenced this pull request Feb 9, 2021
CPython fixed the same issue in python/cpython#10419. Seems like under pressure, more write callbacks may happen before _remove_writer() is called, so we should check for done(). FixesMagicStack#378
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
add_done_callback()to unsubscribe reader/writer early on calcellation.https://bugs.python.org/issue30064