CURATOR-674. Apply code style with spotless#463
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
tisonkun changed the title Signed-off-by: tison <[email protected]>
MemberAuthor
tisonkun commented Jun 1, 2023
Updated. PTAL @kezhuw@cammckenzie@eolivelli |
kezhuw approved these changes Jun 1, 2023
Member
kezhuw left a comment
kezhuw left a comment There was a problem hiding this comment.
+1
I reviewed the first commit and trust CI for remains.
| <configuration> | ||
| <java> | ||
| <palantirJavaFormat> | ||
| <version>2.30.0</version> |
MemberAuthor
There was a problem hiding this comment.
Make sense. As this PR already touch a large range of code. I tend to postpone this suggestion after we merge this one.
Member
kezhuw commented Jun 2, 2023
MemberAuthor
tisonkun commented Jun 2, 2023
As we agree on the mailing list already, I'll merge this patch in hours. |
MemberAuthor
tisonkun commented Jun 2, 2023
Merging... |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit is the real plugin and CI change. The second commit is generated by running
./mvnw spotless:apply.The discussion thread can be found at https://lists.apache.org/thread/12rwy3y1zcs3pjh9q30851mldgdh4sgg
If we agree on the direction, I'll file a ticket for this.