Accept TDigest bytes with buffered values#704
Merged
+79 −33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
tisonkun commented Dec 19, 2025
MemberAuthor
There was a problem hiding this comment.
Help IDEA to properly format files without large indentation changes. Can be removed if you don't like to check it into the VCS but IMO it does no harm.
MemberAuthor
There was a problem hiding this comment.
Out of the thread: spotless can help in autoformat over checkstyle
See also:
tisonkun commented Dec 19, 2025
| for (finalintn : nArr){ | ||
| finalbyte[] bytes; | ||
| if (buffered){ | ||
| bytes = Files.readAllBytes(cppPath.resolve("tdigest_double_buf_n" + n + "_cpp.sk")); |
MemberAuthor
There was a problem hiding this comment.
This will fail without this patch.
leerho approved these changes Dec 19, 2025
leerho merged commit ca1fef0 into apache:main 7 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes#701.